Fri 18 Apr 2008
I ran across this piece of code in a program I am updating. The original author is a great game designer, but only a fair programmer. He also seems to have very limited experience with SQL.
[php]
if ( $grab == ‘Ammo’ ) {
$check = mysql_query(”SELECT * FROM BF WHERE owner= ‘None’ AND country=’$fetch->location’”);
$num_rows = mysql_num_rows($check);
if ( $num_rows != 0 ) {
if ( $fetch->location == $location ) {
mysql_query(”UPDATE BF SET owner=’$username’, profit=’0′ WHERE country=’$fetch->location’ LIMIT 1″);
$this->content .= “You got the Bullet Factory!”;
}
}
}
[/php]
When writing database applications, you need to be as good at writing queries as you are at writing code. Here’s a rewrite: