Fri 18 Apr 2008
A Little Bit of SQL
Posted by Charles Clarkson under PHP, Programming
No Comments
I ran across this piece of code in a program I am updating. The original author is a great game designer, but only a fair programmer. He also seems to have very limited experience with SQL.
- if ( $grab == 'Ammo' ) {
- if ( $num_rows != 0 ) {
- if ( $fetch->location == $location ) {
- mysql_query("UPDATE BF SET owner='$username', profit='0' WHERE country='$fetch->location' LIMIT 1");
- $this->content .= "You got the Bullet Factory!";
- }
- }
- }
When writing database applications, you need to be as good at writing queries as you are at writing code. Here's a rewrite:
(more...)